Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vector collection API - search, optimize, clear, size #679

Merged
merged 11 commits into from
Jun 21, 2024
Merged

Update vector collection API - search, optimize, clear, size #679

merged 11 commits into from
Jun 21, 2024

Conversation

k-jamroz
Copy link
Contributor

@k-jamroz k-jamroz commented Jun 14, 2024 •
edited
Loading

Implement client side changes related to recent client protocol changes and some cleanup:

  • move vector to top-level search parameter
  • add search hints (minimal API with Dict[str, str], can be improved later to be more python-like)
  • add optimize and clear
  • add size
  • fix automatically generated codecs (Fix generation of python vector codecs hazelcast-client-protocol#528)
  • additional vector JARs are no longer needed
  • add Document.__repr__ for easier printing
  • removed default search limit, -1 was invalid value
  • use V7 license key for tests

@k-jamroz
Update vector collection client after recent changes
ad636d0 
- move vector to top-level search parameter
- add optimize and size
- fix automatically generated codecs
@k-jamroz
Add tests for new methods, remove need for additional vector jars
06b90a9
@k-jamroz k-jamroz requested a review from yuce June 14, 2024 15:46
@k-jamroz k-jamroz changed the title Update vector collection client after recent changes Update vector collection API - search, optimize, size Jun 14, 2024
@k-jamroz
Copy link
Contributor Author

In order for vector collection tests to pass we need V7 license

@k-jamroz k-jamroz changed the title Update vector collection API - search, optimize, size Update vector collection API - search, optimize, clear Jun 14, 2024
@k-jamroz k-jamroz mentioned this pull request Jun 14, 2024
Merged
@k-jamroz k-jamroz requested a review from srknzl June 14, 2024 15:56
@k-jamroz k-jamroz mentioned this pull request Jun 14, 2024
Merged
@k-jamroz k-jamroz changed the title Update vector collection API - search, optimize, clear Update vector collection API - search, optimize, clear, size Jun 18, 2024
yuce
yuce requested changes Jun 20, 2024
View reviewed changes
hazelcast/proxy/vector_collection.py Outdated Show resolved Hide resolved
hazelcast/proxy/vector_collection.py Show resolved Hide resolved
hazelcast/vector.py Outdated Show resolved Hide resolved
@k-jamroz k-jamroz requested a review from yuce June 20, 2024 14:02
yuce
yuce previously approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@yuce yuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@yuce yuce merged commit 1d4f241 into hazelcast:master Jun 21, 2024
5 of 9 checks passed
@yuce yuce added this to the 5.5.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuce yuce yuce approved these changes

@srknzl srknzl Awaiting requested review from srknzl

Assignees
No one assigned
Labels
Source: Internal Type: Enhancement
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@k-jamroz @yuce