Add support for backup count in Vector Collection configuration [AI-145] #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-jamroz
force-pushed
the
vector-backup-count
branch
from
2a25586
to
830e278
Compare
srknzl
reviewed
Oct 2, 2024
| @@ -169,6 +169,38 @@ def test_size(self): | |||
| self.vector_collection.clear() | |||
| self.assertEqual(self.vector_collection.size(), 0) | |||
|
|
|||
| def test_backupCount_valid_values_pass(self): | |||
There was a problem hiding this comment.
does this work with the 5.5 server? I didnt get why we skip tests below but not this
There was a problem hiding this comment.
yes, 5.5 server ignores backup counts in client message so it does not validate them
srknzl
approved these changes
Oct 3, 2024
yuce
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backup count configuration for vector collection was added in hazelcast/hazelcast-client-protocol#533
New parameters need #699 but the tests work with both 5.5 (skipped) and 6.0.