Update hazelcast wm to 5.x.y compatibility (redux) [HZG-17] #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit baed8ed.
& change protected methods to public after refactor
srknzl
changed the title
hasancelik
approved these changes
May 28, 2024
frant-hartm
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux of #127. It's reverted due to a merge related problem.
Prepare for release 5.0-SNAPSHOT
Uses tomcat 9.0.z because of https://hazelcast.atlassian.net/browse/SUP-420?focusedCommentId=97796
I changed the java version of PR builder to 17 because hazelcast 5.4 requires min 17
I tried spring session repl. guide locally with use-client:true/false and hz versions changing from 5.0 -> 5.5
Changes:
The main change is pom.xml. The new profiles are meant to be tested using https://jenkins.hazelcast.com/job/WM-pr-builder-different-versions-test/ (manual trigger).
There're refactors and copyright changes.
what I call refactor is basically about separation of jetty specific tests from others to be able to test jdk8 + tomcat 9 case (SUP-420 case, we don't know their jdk version but tomcat's min is 1.8)
some very small code changes to make dependencies work
and tiny bit of readme change