Document Vert.x integration [DEX-172] #1280
Open
+608
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frant-hartm
requested review from
oliverhowell and
amandalindsay
as code owners
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| See the Vert.x Hazelcast Cluster Manager site for reference documentation of the `vertx-hazelcast` module. | ||
|
|
||
| You can also follow our xref:vertx-step-by-step-buide.adoc[step-by-step guide]. |
There was a problem hiding this comment.
Check if this link works because it states 'buide' not 'guide'
| We will fix that by using a Hazelcast Cluster Manager. There are two modules that provide Hazelcast Cluster Manager: | ||
|
|
||
| - `io.vertx:vertx-hazelcast` - this module is maintained by the Vert.x team, with contributions from Hazelcast, and is built on top of open-source Hazelcast | ||
| - `com.hazelcast:vertx-hazelcast-enterprise` / this module is maintained by the Hazelcast team and is built on top of the `vertx-hazelcast` but uses Hazelcast Enterprise instead. You need an enterprise license to use Hazelcast Enterprise. |
There was a problem hiding this comment.
Should the / be a - (hyphen) instead?
There was a problem hiding this comment.
yes, fixed in 62101ff
| </dependency> | ||
| ---- | ||
|
|
||
| change the following part of the `start` method |
There was a problem hiding this comment.
where possible, add ":" (a colon) at the end of lines where information follows
amandalindsay
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Looks like page needs renamed 'buide' to 'guide'
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
Co-authored-by: Amanda Lindsay <[email protected]>
amandalindsay
requested changes
Oct 15, 2024
|
|
||
| == Using Vert.x Hazelcast Cluster Manager | ||
|
|
||
| See the Vert.x Hazelcast Cluster Manager site for reference documentation of the `vertx-hazelcast` module. |
There was a problem hiding this comment.
Suggested change
| See the Vert.x Hazelcast Cluster Manager site for reference documentation of the `vertx-hazelcast` module. | |
| See the Vert.x Hazelcast Cluster Manager site for reference documentation for the `vertx-hazelcast` module. |
|
|
||
| See the Vert.x Hazelcast Cluster Manager site for reference documentation of the `vertx-hazelcast` module. | ||
|
|
||
| You can also follow our xref:vertx-step-by-step-guide.adoc[step-by-step guide]. |
There was a problem hiding this comment.
Suggest changing the name of the guide to "Get started with Vert.x guide"
| java -jar target/messages-1.0.0-SNAPSHOT-fat.jar | ||
| ---- | ||
|
|
||
| you should see an output similar to the following: |
There was a problem hiding this comment.
Suggested change
| you should see an output similar to the following: | |
| You should see output similar to the following: |
| INFO: Succeeded in deploying verticle | ||
| ---- | ||
|
|
||
| [NOTE] |
There was a problem hiding this comment.
Is the following 'ToDo' content hidden?
|
|
||
| Go to the `MainVerticle.java` file and replace the contents of the start method with the following: | ||
|
|
||
| NOTE: This guide uses 2 space indentation, which is customary for Vertx projects due to the high number of nested callbacks. |
There was a problem hiding this comment.
Suggested change
| NOTE: This guide uses 2 space indentation, which is customary for Vertx projects due to the high number of nested callbacks. | |
| NOTE: This guide uses 2-space indentation, which is customary for Vertx projects due to the high number of nested callbacks. |
| </dependency> | ||
| ---- | ||
|
|
||
| change the following part of the `start` method: |
There was a problem hiding this comment.
Suggested change
| change the following part of the `start` method: | |
| Change the following part of the `start` method: |
| ... | ||
| ---- | ||
|
|
||
| putting two messages into different instances while using the same cookie we see that the session is shared between the instances. |
There was a problem hiding this comment.
Suggested change
| putting two messages into different instances while using the same cookie we see that the session is shared between the instances. | |
| Putting two messages into different instances while using the same cookie, we see that the session is shared between the instances. |
| ... | ||
| ---- | ||
|
|
||
| enable the CP subsystem, and in cluster.xml change the value of the `` property to `3`: |
There was a problem hiding this comment.
Suggested change
| enable the CP subsystem, and in cluster.xml change the value of the `` property to `3`: | |
| Enable the CP subsystem, and in cluster.xml change the value of the `` property to `3`: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.