-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title Editor, Exercise Keying with UUID, Mutant Editing, and New Persistent State Type #1316
base: dev
Are you sure you want to change the base?
Conversation
…te while in instructor mode
…ser is editing title, also automated swapping between focus on title-box/editors
…es, this also solves issue of text-box with incorrect value persisting across exercise slides when switching while editing
…hen switching between exercise slides; added confirm and cancel edit buttons for finalizing title updates (or cancelling them), this also fixes a bug with pressing enter to confirm where it would also press enter in the respective code editor where the cursor was located
… are non-functional still)
…to-do: allow editing of implementation hints as they default to "no hint available"
@russell-rozenbaum did you intend to close this issue? |
I've added more changes beyond just the title editor to this branch, to be exact I added some implementations to adding and deleting buggy implementations, so I wasn't sure whether to move those commits to a different branch or finish them out fully before opening this pull request |
Commit [968fe1c] is the one I'd like to merge. The last 2 commits add the ability to add/delete buggy implementations, which I'll start on another branch. The problem with the current version is a bug that occurs when adding a wrong implementation (which is itself an editor) and then I believe the program does not know where to put the cursor on page reload since the editors are reset (the one previously added, now deleted on page reload), and results in an infinite loading screen. Besides this, I still want to add the ability to edit the hints associated with buggy implementations, which right now defaults to "no hint available". |
a1e82bf
to
968fe1c
Compare
…to-do: allow editing of implementation hints as they default to "no hint available
…s to be set off read-only
… : string, version : int) pairs; edited title now saves on refresh
… and load added/deleted mutants
… and load added/deleted mutants
… and load added/deleted mutants
30c1035
to
ebdaefb
Compare
@russell-rozenbaum there are some merge conflicts and a build failure here |
bdfe77b
to
229b969
Compare
54f7ac5
to
d31a338
Compare
…bugs; persistent_state_of_state and unpersist_state updated to now save and load to and from local memory respectively
Goal
Implement the ability to make changes to the exercise title while in instructor mode. These changes should persist through page refreshes, switching between exercise slides, and in exercise exports.
Convert exercise mode's local storage keying system from (string, int) pairs to Uuidm types
Implementation Strategy
Added Features
Potential Pitfalls