Skip to content

Commit

Permalink
[clarity] Deprecate sign and add signPassphrase for better clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
hazendaz committed Oct 1, 2023
1 parent 27c5bc8 commit 5614aaf
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion src/main/java/com/hazendaz/maven/makeself/MakeselfMojo.java
Original file line number Diff line number Diff line change
Expand Up @@ -445,11 +445,22 @@ public class MakeselfMojo extends AbstractMojo {
private Boolean sha256;

/**
* -sign passphrase : Signature private key to sign the package with.
* --sign passphrase : Signature private key to sign the package with.
*
* @deprecated use 'signPassphrase'
*/
@Deprecated
@Parameter(property = "sign")
private String sign;

/**
* --sign passphrase : Signature private key to sign the package with.
*
* @since 1.6.0
*/
@Parameter(property = "signPassphrase")
private String signPassphrase;

/**
* --lsm file : Provide and LSM file to makeself, that will be embedded in the generated archive. LSM files are
* describing a software package in a way that is easily parseable. The LSM entry can then be later retrieved using
Expand Down Expand Up @@ -1184,6 +1195,12 @@ private List<String> loadArgs() {
args.add(sign);
}

// --sign passphrase : Signature private key to sign the package with
if (signPassphrase != null) {
args.add("--sign");
args.add(signPassphrase);
}

// --target dir : Specify the directory where the archive will be extracted. This option implies
// --notemp and ddoes not require aq startup_script.
if (extractTargetDir != null) {
Expand Down

0 comments on commit 5614aaf

Please sign in to comment.