Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between the global viewspace and a view group #63

Merged
merged 19 commits into from
Jun 18, 2023

Conversation

mvanderkamp
Copy link
Contributor

@mvanderkamp mvanderkamp commented Jun 18, 2023

Differentiates between the Viewspace (a new class) and ServerViewGroups. This allows the creation of groups that are only a subset of the total number of views.

  • The layouts don't yet support this. I think we need to incorporate layouts into ServerViewGroups and also have the ServerViewGroups or something similar track devices. Perhaps the view should know it's associated device.
  • The related code and concepts may still need some iteration.

Includes a bit of cleanup to help with this:

  • Rename ServerGroup -> ServerItemGroup
  • Rename createGroup -> createItemGroup
  • Attach settings to the Application instead of the workspace
  • Store fewer references to the workspace
  • Use application.emit directly instead of messageHandler.send
  • Store fewer references to the MessageHandler
  • Don't pass workspace into message handler separately
  • Only pass the client limit, not all settings, to the switchboard
  • Document more settings
  • Fix formatting
  • Sort and add warnings to settings
  • Fix bug from not using this. before settings - missed default
  • Remove commented-out line

Closes #62

@mvanderkamp mvanderkamp added this to the Conference milestone Jun 18, 2023
@mvanderkamp mvanderkamp added server Affects server code examples Affects example applications cleanup Refactor or general cleanup that doesn't change behaviour but makes code easier to read and maintain labels Jun 18, 2023
@mvanderkamp mvanderkamp self-assigned this Jun 18, 2023
@mvanderkamp mvanderkamp changed the title Simplify and clean up the organization of the server to prepare for Viewspace changes Distinguish between the global viewspace and a view group Jun 18, 2023
@mvanderkamp mvanderkamp merged commit 446986f into main Jun 18, 2023
1 check passed
@mvanderkamp mvanderkamp deleted the server-cleanup branch June 18, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactor or general cleanup that doesn't change behaviour but makes code easier to read and maintain examples Affects example applications server Affects server code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "Viewspace" for views, don't automatically add views to a group
1 participant