Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interaction in the Chess example #65

Merged
merged 7 commits into from
Jun 18, 2023
Merged

Fix interaction in the Chess example #65

merged 7 commits into from
Jun 18, 2023

Conversation

mvanderkamp
Copy link
Contributor

@mvanderkamp mvanderkamp commented Jun 18, 2023 •
edited
Loading

At some point interaction broke down in the chess example. I fixed and cleaned it up.

  • Define the board as one item.
  • Spawn pieces as canvas images instead of HTML elements
  • Simplifications and reorganization
  • Fix inverted player indexes
  • Show each player their pieces as upright

Closes #64

@mvanderkamp mvanderkamp added this to the Conference milestone Jun 18, 2023
@mvanderkamp mvanderkamp added bug Something isn't working examples Affects example applications cleanup Refactor or general cleanup that doesn't change behaviour but makes code easier to read and maintain labels Jun 18, 2023
@mvanderkamp mvanderkamp self-assigned this Jun 18, 2023
@mvanderkamp mvanderkamp merged commit 9a42159 into main Jun 18, 2023
1 check passed
@mvanderkamp mvanderkamp deleted the fix-chess-interaction branch June 18, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mvanderkamp mvanderkamp

Labels
bug Something isn't working cleanup Refactor or general cleanup that doesn't change behaviour but makes code easier to read and maintain examples Affects example applications
Projects
None yet
Milestone
Conference
Development

Successfully merging this pull request may close these issues.

Fix interaction in the chess example
1 participant
@mvanderkamp