Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup around gestures and items #73

Merged
merged 11 commits into from
Jun 22, 2023
Merged

Conversation

mvanderkamp
Copy link
Contributor

@mvanderkamp mvanderkamp commented Jun 22, 2023

  • Remove unused transform()
  • Forward as much of the original event as possible
  • Rename processSwivel -> handleSwivel
  • Use type='item' since that's what the switch statement looks for
  • An item is considered lockable if it has any event listeners attached
  • Shorten timeout before removing swipe tail
  • Optimize adding items: don't require a second packet to set sequence etc
  • Send a minimal packet when asking to remove an item
  • Make more use of the shared bases

@mvanderkamp mvanderkamp added this to the Conference milestone Jun 22, 2023
@mvanderkamp mvanderkamp added client Affects client deliverables server Affects server code examples Affects example applications cleanup Refactor or general cleanup that doesn't change behaviour but makes code easier to read and maintain labels Jun 22, 2023
@mvanderkamp mvanderkamp self-assigned this Jun 22, 2023
@mvanderkamp mvanderkamp merged commit a63dfc1 into main Jun 22, 2023
1 check passed
@mvanderkamp mvanderkamp deleted the gesture-cleanup branch June 22, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactor or general cleanup that doesn't change behaviour but makes code easier to read and maintain client Affects client deliverables examples Affects example applications server Affects server code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant