Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize wheel events across browsers #76

Merged
merged 14 commits into from
Jun 27, 2023
Merged

Normalize wheel events across browsers #76

merged 14 commits into from
Jun 27, 2023

Conversation

mvanderkamp
Copy link
Contributor

I noticed that wheel events can be inconsistent, and found a library that helps with that.

  • Install and use the normalize-wheel package
  • Constrain amount of zoom on a wheel event
  • move drawing-app.js -> index.js so example can be excecuted more easily
  • Add background colour
  • Set "touch-action: none" on the canvas so that pointer events work correctly
  • Don't emit wheel event if data is missing

@mvanderkamp mvanderkamp self-assigned this Jun 27, 2023
@mvanderkamp mvanderkamp added bug Something isn't working client Affects client deliverables server Affects server code labels Jun 27, 2023
@mvanderkamp mvanderkamp added this to the Conference milestone Jun 27, 2023
@mvanderkamp mvanderkamp merged commit c7d0afa into main Jun 27, 2023
@mvanderkamp mvanderkamp deleted the normalize-wheel branch June 27, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mvanderkamp mvanderkamp

Labels
bug Something isn't working client Affects client deliverables server Affects server code
Projects
None yet
Milestone
Conference
Development

Successfully merging this pull request may close these issues.
1 participant
@mvanderkamp