Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column for storing visualization embeddings #20

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Conversation

ajtritt
Copy link
Contributor

@ajtritt ajtritt commented Jan 7, 2025

Motivation

It would be convenient to be able to store 2D or 3D embeddings meant for visualization alongside other AI outputs

How to test the behavior?

rt = ResultsTable(name="foo", description="a test results table")
rt.add_viz_embedding([[1.1, 2.9], [1.2, 2.8], [1.3, 2.7], [1.4, 2.6], [1.5, 2.5]])

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@ajtritt ajtritt requested a review from rly January 7, 2025 20:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (b5923f7) to head (d2556d1).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   82.87%   82.23%   -0.64%     
==========================================
  Files           2        2              
  Lines         146      152       +6     
  Branches       32       33       +1     
==========================================
+ Hits          121      125       +4     
- Misses         20       22       +2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajtritt ajtritt merged commit a9253f8 into main Jan 7, 2025
3 of 8 checks passed
@ajtritt ajtritt deleted the enh/vizemb branch January 7, 2025 22:53
@rly
Copy link
Contributor

rly commented Jan 8, 2025

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants