Skip to content

Commit

Permalink
update CHANGELOG.md
Browse files Browse the repository at this point in the history
  • Loading branch information
magland committed Mar 6, 2024
1 parent 2ac5a3f commit 29adcca
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### Enhancements

* Changed default object_codec_class for ZarrIO to numcodecs.JSON. The issue with the old default (numcodecs.Pickle) was that it was not readable outside of Python. Also, exposed the object_codec_class as a parameter to the NWBZarrIO constructor.
* Changed default object_codec_class for ZarrIO to numcodecs.JSON. The issue with the old default (numcodecs.Pickle) was that it was not readable outside of Python. Exposed the object_codec_class as a parameter to the NWBZarrIO constructor. Resort to Pickle for complex cases such as structured arrays or compound datasets with refs.

## 0.6.0 (February 21, 2024)

Expand Down
4 changes: 2 additions & 2 deletions src/hdmf_zarr/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,7 @@ def write_dataset(self, **kwargs): # noqa: C901

object_codec = self.__codec_cls()
if not isinstance(object_codec, numcodecs.Pickle):
print(f'Resorting to Pickle codec for dataset {name} of {parent.name}')
warnings.warn(f'Resorting to Pickle codec for dataset {name} of {parent.name}')
object_codec = numcodecs.Pickle()

# cast and store compound dataset
Expand Down Expand Up @@ -1287,7 +1287,7 @@ def __list_fill__(self, parent, name, data, options=None): # noqa: C901
if has_structured_array:
object_codec = io_settings.get('object_codec')
if not isinstance(object_codec, numcodecs.Pickle):
print(f'Warning: Resorting to Pickle codec for {name} of {parent.name}.')
warnings.warn(f'Resorting to Pickle codec for {name} of {parent.name}.')
io_settings['object_codec'] = numcodecs.Pickle()

# Create the dataset
Expand Down

0 comments on commit 29adcca

Please sign in to comment.