Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pathlib #212

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Support Pathlib #212

wants to merge 4 commits into from

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Aug 20, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Fix #181

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (82c993c) to head (d9fb0c9).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #212      +/-   ##
==========================================
+ Coverage   87.13%   87.17%   +0.03%     
==========================================
  Files           5        5              
  Lines        1174     1177       +3     
  Branches      287      288       +1     
==========================================
+ Hits         1023     1026       +3     
  Misses        100      100              
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor Author

The coverage for the patch is 100%. We are good.

@mavaylon1 mavaylon1 marked this pull request as ready for review August 21, 2024 15:17
@h-mayorquin
Copy link

Great!

Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support pathlib.Path in ZarrIO
4 participants