Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hdmf-zarr workflow #1222

Merged
merged 2 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/run_hdmf_zarr_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,17 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.10' # use 3.10 until hdmf-zarr updates versioneer.py which breaks on newer python
python-version: '3.13'

- name: Update pip
run: python -m pip install --upgrade pip

- name: Clone HDMF-Zarr and install dev branch of HDMF
run: |
python -m pip list
git clone https://github.com/hdmf-dev/hdmf-zarr.git --recurse-submodules
git clone https://github.com/hdmf-dev/hdmf-zarr.git
cd hdmf-zarr
python -m pip install -r requirements-dev.txt # do not install the pinned install requirements
python -m pip install . # this will install a different version of hdmf from the current one
python -m pip install .[test] # this will install a different version of hdmf from the current one
cd ..
python -m pip uninstall -y hdmf # uninstall the other version of hdmf
python -m pip install . # reinstall current branch of hdmf
Expand All @@ -41,4 +40,4 @@ jobs:
- name: Run HDMF-Zarr tests on HDMF-Zarr dev branch
run: |
cd hdmf-zarr
pytest
pytest -v
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- Added support for expandable datasets of references for untyped and compound data types. @stephprince [#1188](https://github.com/hdmf-dev/hdmf/pull/1188)
- Improved html representation of data in `Container` objects. @h-mayorquin [#1100](https://github.com/hdmf-dev/hdmf/pull/1100)
- Added error when using colon for `Container` name. A colon cannot be used as a group name when writing to Zarr on Windows. @stephprince [#1202](https://github.com/hdmf-dev/hdmf/pull/1202)
- Adjusted testing for hdmf-zarr. @rly [#1222](https://github.com/hdmf-dev/hdmf/pull/1222)

### Bug fixes
- Fixed inaccurate error message when validating reference data types. @stephprince [#1199](https://github.com/hdmf-dev/hdmf/pull/1199)
Expand Down
Loading