Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return breaking changes removing deprecated classes & functions #1227

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 6, 2025

Bring back breaking changes reverted in #1224.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (d63e588) to head (44e1ab1).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/hdmf/backends/hdf5/h5tools.py 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1227      +/-   ##
==========================================
+ Coverage   89.00%   90.86%   +1.85%     
==========================================
  Files          45       42       -3     
  Lines        9969     9524     -445     
  Branches     2833     2725     -108     
==========================================
- Hits         8873     8654     -219     
+ Misses        774      576     -198     
+ Partials      322      294      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly requested a review from oruebel January 6, 2025 22:45
@rly rly enabled auto-merge (squash) January 6, 2025 22:45
oruebel
oruebel previously approved these changes Jan 9, 2025
@rly rly merged commit 85c9af8 into dev Jan 9, 2025
24 of 26 checks passed
@rly rly deleted the breaking branch January 9, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants