frontend: Add websocket multiplexer #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend Code coverage changed from 61.1% to 61.2%. Change: .1% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
a3b5f1f to
e23dd95
Compare
dosubot
bot
added
the
size:XL
|
Backend Code coverage changed from 61.1% to 61.1%. Change: 0% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
e23dd95 to
af50857
Compare
|
Backend Code coverage changed from 61.0% to 61.2%. Change: .2% 😃. Coverage report |
|
Hi, I've tried the test case that you've described and it doesn't work for me. It enters some kind of loop and keeps rerendering pod-creation-loop.mp4Another thing I've tried is setting allowed namespaces (default and store) in setting
Then went to pods page and it connects to the first namespace twice, but should connect to both default and store
|
|
What is the purpose of the STATUS message? I don't see it being used on the frontend
|
|
So websocket connection can be of 4 types
|
sniok
requested changes
Nov 14, 2024
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
af50857 to
8484f79
Compare
|
Backend Code coverage changed from 61.1% to 61.2%. Change: .1% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
8484f79 to
146c4db
Compare
|
Backend Code coverage changed from 61.0% to 61.1%. Change: .1% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
146c4db to
6055579
Compare
|
Backend Code coverage changed from 61.0% to 61.2%. Change: .2% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
6055579 to
091b60a
Compare
|
Backend Code coverage changed from 61.0% to 61.1%. Change: .1% 😃. Coverage report |
|
I've tried the "k run nginx" case again and it worked but I noticed that it recreates the connection on every update First it receives new pod {
"clusterId": "olek-test-cluster",
"path": "/api/v1/namespaces/default/pods",
"query": "watch=1&resourceVersion=34249370",
"userId": "4bd01bb98296b9e2",
"data": "{\"type\":\"ADDED...",
"type": "DATA"
}then frontend sends a close signal {
"clusterId": "olek-test-cluster",
"path": "/api/v1/namespaces/default/pods",
"query": "watch=1&resourceVersion=34249370",
"userId": "4bd01bb98296b9e2",
"type": "CLOSE"
}and then right after that it requests a new connection with a new resource version {
"clusterId": "olek-test-cluster",
"path": "/api/v1/namespaces/default/pods",
"query": "watch=1&resourceVersion=34249403",
"userId": "4bd01bb98296b9e2",
"type": "REQUEST"
} |
illume
reviewed
Nov 18, 2024
|
Note: Olek did some more tests for useWatchKubeObjecfLists which have been merged into main now. |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
091b60a to
ceca8d2
Compare
|
Backend Code coverage changed from 61.0% to 61.1%. Change: .1% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
ceca8d2 to
b96d1ad
Compare
|
Sure, make sense |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
a48b943 to
839bd41
Compare
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
839bd41 to
fff39d1
Compare
|
Addressed changes, please review |
|
Backend Code coverage changed from 61.1% to 63.6%. Change: 2.5% 😃. Coverage report |
|
Backend Code coverage changed from 61.1% to 63.5%. Change: 2.4% 😃. Coverage report |
|
Thanks for the changes. Looking forward to merging this soon! 🎉 I updated the convos still open, and left notes about the ones with stuff still to go. A summary of what's remaining:
It would be nice if we could get a review from Santhosh on the backend parts at least for security/correctness. But this could also come post merge (but before it's released). It's important to merge it in earlier in this release cycle so it can get more day to day use. |
yolossn
reviewed
Dec 30, 2024
yolossn
reviewed
Dec 30, 2024
This adds a single websocket connection from frontend to backend and sends lists of messages to the backend. With the help of messages backend creates multiple websocket connection to k8s API and returns back the data. This solves the issue for limiting of websocket connection in frontend in case of multi cluster setup. Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
fff39d1 to
b044c01
Compare
|
Backend Code coverage changed from 60.8% to 63.3%. Change: 2.5% 😃. Coverage report |
Now websocket has clear type that is needs to sends. This also fixes panic of websocket in various edge cases. Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
b044c01 to
5978d86
Compare
|
Backend Code coverage changed from 60.9% to 63.6%. Change: 2.7% 😃. Coverage report |
This adds a new way to use new way to run websocket multiplexer. Default way would be the legacy way which creates multiple websocket connection. This adds a new flag `REACT_APP_ENABLE_WEBSOCKET_MULTIPLEXER` to run the new API. Signed-off-by: Kautilya Tripathi <[email protected]>
Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
5978d86 to
28003c3
Compare
|
Backend Code coverage changed from 60.8% to 63.6%. Change: 2.8% 😃. Coverage report |
I got following error. |
|
Thanks @farodin91 |
|
Thanks @farodin91 opened a fix for it in #2731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a single websocket connection from frontend to backend and sends lists of messages to the backend. With the help of messages backend creates multiple websocket connection to k8s API and returns back the data.
This solves the issue for limiting of websocket connection in frontend in case of multi cluster setup.
Fixes: #2515
Testing
cd frontend && npm run start #(default is multiplexer enabled)cd backend && go run ./cmd -dev -enable-dynamic-clusterskubectl run nginx --image=nginxTODO
cd backend && go test -race -v -p 1 ./...