Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address interpolation for pelias search endpoint #250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ellenhp
Copy link
Member

@ellenhp ellenhp commented Feb 23, 2023

The search endpoint isn't currently used, but it could be a good fallback for searches with no results. I know YAGNI and all is a good guideline for merging code that isn't used but I do think it would be nice to support this eventually so I'm going to PR it and maybe a new branch can be based on it that adds a fallback to the search endpoint if the autocomplete one fails.

I also probably changed too much in the earthfile but since if you want to merge this I can clean it up :)

  • Add k8s config for interpolation (or decide against it, given that interpolation artifact generation can take close to a week at planet scale IIRC)
  • Clean up earthfile changes

@ellenhp
Copy link
Member Author

ellenhp commented Mar 16, 2023

@michaelkirk How are you feeling about this change, assuming I can clean it up and make a corresponding frontend change to add a search endpoint fallback when there are zero results? My gut says we need to make interpolation optional because planet-scale interpolation artifact generation supposedly takes like a week or more. Thoughts?

@michaelkirk
Copy link
Member

michaelkirk commented Mar 16, 2023

Sorry to leave you hanging there. I feel like address interpolation would be a great feature to integrate.

Before merging, I'd prefer that it be visibly functioning (with UI, like you mentioned), ideally including a way to continuously demonstrate/evaluate it.

Making it optional, and probably avoiding it for the maps.earth planet build makes sense, based on what you're saying about the build times. Do you think it'd be reasonable to add to seattle.maps.earth?

The k8's configs for that live at https://github.com/headwaymaps/headway/tree/main/k8s/configs/seattle-dev
But they are generated by https://github.com/headwaymaps/headway/blob/main/k8s/bin/regenerate-all#L10

The whole k8s generation thing I came up with is pretty heinous, but it works just well enough that I haven't prioritized coming up with something better. Feel free to ask questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants