Add event based metrics #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turian
reviewed
Nov 20, 2021
| "event_postprocessing_grid" | ||
| ] | ||
| else: | ||
| postprocessing_grid = EVENT_POSTPROCESSING_GRID |
There was a problem hiding this comment.
EVENT_POSTPROCESSING_GRID can we just remove this and have a specific dcase grid and no default? If this is tricky let's just make an issue for it.
turian
reviewed
Nov 20, 2021
turian
reviewed
Nov 20, 2021
| ), | ||
| "event_onset_offset_50ms_20perc_fms": partial( | ||
| EventBasedScore, | ||
| name="event_onset_offset_50ms_20perc_fms", |
There was a problem hiding this comment.
In MAESTRO paper (and our doc), they use fms + prc + rcl. Is it possible (and not too hard) to compute all three without running sed_eval three times (which is slow)? Maybe we could even run EventBasedScore just once for both onset f+p+r and onset+offset f+p+r. Like one sed_eval for all six?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.