Save Predictions + Add prediction logging #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khumairraj
changed the title
turian
reviewed
Nov 21, 2021
turian
reviewed
Nov 21, 2021
turian
reviewed
Nov 21, 2021
turian
reviewed
Nov 21, 2021
| open( | ||
| embedding_path.joinpath(f"{test_fold_str}.predicted-labels.pkl"), "wb" | ||
| ), | ||
| ) |
There was a problem hiding this comment.
a) We can't do any interesting downstream analysis unless predictions AND targets are pickled. This MUST be fixed.
b) Is it difficult to pickle these scores where the test stuff is actually computed, rather than relying upon nebulous global state that may change? (For b) maybe make an issue and move on.)
There was a problem hiding this comment.
By global state, I mean split_grid_points[i].predictor.test_predicted_labels. Maybe this is okay. but we still must fix a)
There was a problem hiding this comment.
Targets were already saved from before by the embedding module. @jorshi Thanks for adding it here as well along with the prediction logits. Will be in one place.
turian
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.