Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove Pixels from Application #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PatrickMetsch
Copy link
Contributor

Not really sure what situations call for 'em' and which call for "vh/vw"

Didn't want to dive too deep into the overhaul without some feedback, but no changes made so far have negatively impacted the layout of the site.

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #242 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   41.52%   41.54%   +0.02%     
==========================================
  Files         329      328       -1     
  Lines        1811     1810       -1     
  Branches      113      113              
==========================================
  Hits          752      752              
+ Misses       1059     1058       -1
Impacted Files Coverage Δ
src/frontEnd/forms/InputForField.tsx 0% <ø> (ø) ⬆️
src/frontEnd/page/ComponentWithOverlay.tsx 0% <ø> (ø) ⬆️
...c/frontEnd/volunteering/LoadVolunteeringOption.tsx 0% <ø> (ø) ⬆️
src/frontEnd/search/HPSearchResult.tsx 0% <ø> (ø) ⬆️
src/frontEnd/search/theme.ts 0% <ø> (ø) ⬆️
src/frontEnd/modals/CelebrationModal.tsx 0% <ø> (ø) ⬆️
src/frontEnd/nav/SideNav.tsx 0% <ø> (ø) ⬆️
src/frontEnd/volunteering/VolunteeringPreview.tsx 0% <ø> (ø) ⬆️
src/frontEnd/nav/HeartpointsLogoAndName.tsx 0% <ø> (ø) ⬆️
src/frontEnd/page/Space.tsx 0% <ø> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3fb60...3aa0d25. Read the comment docs.

@PatrickMetsch
Copy link
Contributor Author

@tommy. Take a look and merge at your leisure. Thanks!

Copy link
Member

@tommysullivan tommysullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this looks ok then ship it!

@bob-bins
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants