cmake: Redesign bitcoin_crypto and bitcoin_consensus libraries
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this command, we are free to `include(CheckSourceCompilesAndLinks)` wherever we want. It won't be duplicated.
The bitcoin_crypto_base interface library only keeps a list of source files, so we can compile them with different preprocessor definitions, at least with and without -DBUILD_BITCOIN_INTERNAL.
The bitcoin_consensus_sources interface library only keeps a list of source files, so we can compile them with different preprocessor definitions, at least with and without -DBUILD_BITCOIN_INTERNAL.
|
Friendly ping @TheCharlatan @theuni @vasild @fanquake @pablomartin4btc @m3dwards |
TheCharlatan
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
ACK 6433281
Checked that the correct extensions are still activated in crypto, and did not notice behavior changes. Did not check the minimum supported version.
vasild
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source files of both
bitcoin_cryptoandbitcoin_consensuslibraries factored out into interface libraries, which allows us to reuse them when compiling with different build options.That is required to build upcoming shared libraries that, for example, use additional
-DBUILD_BITCOIN_INTERNALpreprocessor flag.No behavior change.
Split from #41.
What to test: