-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for Gen.sample
#373
Conversation
BenchmarkDotNet=v0.13.1, OS=debian 10 (container)
Intel Core i7-9750H CPU 2.60GHz, 8 CPU, 8 logical and 8 physical cores
.NET Core SDK=3.1.413
[Host] : .NET Core 3.1.19 (CoreCLR 4.700.21.41101, CoreFX 4.700.21.41603), X64 RyuJIT DEBUG
.NET Core 3.1 : .NET Core 3.1.19 (CoreCLR 4.700.21.41101, CoreFX 4.700.21.41603), X64 RyuJIT
Job=.NET Core 3.1 Runtime=.NET Core 3.1
|
Also, as a fun side note I removed BenchmarkDotNet=v0.13.1, OS=debian 10 (container)
Intel Core i7-9750H CPU 2.60GHz, 8 CPU, 8 logical and 8 physical cores
.NET Core SDK=3.1.413
[Host] : .NET Core 3.1.19 (CoreCLR 4.700.21.41101, CoreFX 4.700.21.41603), X64 RyuJIT DEBUG
.NET Core 3.1 : .NET Core 3.1.19 (CoreCLR 4.700.21.41101, CoreFX 4.700.21.41603), X64 RyuJIT
Job=.NET Core 3.1 Runtime=.NET Core 3.1
|
I need to refresh my memory on the choice for |
Add And this slightly contradicts my other comment that said to put the quantity to be sampled in the method name. With this change, don't put the quantity in the name. |
I think it was out of concern for generating min/max ranges for |
BenchmarkDotNet=v0.13.1, OS=debian 10 (container)
Intel Core i7-9750H CPU 2.60GHz, 8 CPU, 8 logical and 8 physical cores
.NET Core SDK=3.1.413
[Host] : .NET Core 3.1.19 (CoreCLR 4.700.21.41101, CoreFX 4.700.21.41603), X64 RyuJIT DEBUG
.NET Core 3.1 : .NET Core 3.1.19 (CoreCLR 4.700.21.41101, CoreFX 4.700.21.41603), X64 RyuJIT
Job=.NET Core 3.1 Runtime=.NET Core 3.1
For reference, here's the same benchmarks without BenchmarkDotNet=v0.13.1, OS=debian 10 (container)
Intel Core i7-9750H CPU 2.60GHz, 8 CPU, 8 logical and 8 physical cores
.NET Core SDK=3.1.413
[Host] : .NET Core 3.1.19 (CoreCLR 4.700.21.41101, CoreFX 4.700.21.41603), X64 RyuJIT DEBUG
.NET Core 3.1 : .NET Core 3.1.19 (CoreCLR 4.700.21.41101, CoreFX 4.700.21.41603), X64 RyuJIT
Job=.NET Core 3.1 Runtime=.NET Core 3.1
There is the data graphed, green is Hedgehog+BigInt, Blue is Hedgehog+Int64, Black is FsCheck. |
This looks great. Excellent work @adam-becker! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is ready to merge
@adam-becker, do you think this PR is ready to merge? |
I don't have any experience with BenchmarkDotNet - is it possible to use it to write a test that will fail if, say, HedgehogGenSampleInt32 N=100 takes 1 second? Not a blocker to merging - I'm just wondering. |
I don't think so. The point of a BenchmarkDotNet test is to look at the report it generates. |
This PR puts the examples from #135 into a proper benchmark, in support of #371.
/cc @moodmosaic @TysonMN