Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FAT file system so that FAT formatted disks are recognized #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bvaisvil
Copy link
Contributor

On MacOS, external disks that are formatted with FAT16/FAT32 (yes, I still have some!) are filtered (is_physical) from the list of file systems because the file system name is 'msdos', which isn't in the FileSystem enum.

Before the change:

Partition { device: Some("/dev/disk1s1"), mount_point: "/", file_system: Apfs }
Partition { device: Some("/dev/disk1s4"), mount_point: "/private/var/vm", file_system: Apfs }

After the change:

Partition { device: Some("/dev/disk1s1"), mount_point: "/", file_system: Apfs }
Partition { device: Some("/dev/disk1s4"), mount_point: "/private/var/vm", file_system: Apfs }
Partition { device: Some("/dev/disk2s1"), mount_point: "/Volumes/NO NAME", file_system: Fat }

Though the result from statfs is msdos I made the enum value Fat. Let me know if you'd like something different or to use the existing VFat

@coveralls
Copy link

coveralls commented Apr 27, 2021

Coverage Status

Coverage decreased (-0.6%) to 45.551% when pulling 73b4a97 on bvaisvil:file_system_names into b292f15 on heim-rs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants