Fix a possible segfault in heim::net::nic() for Windows #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daladim
force-pushed
the
nic_segfault
branch
2 times, most recently
from
b51ce33 to
d5f2258
Compare
A null pointer here means "no interface", not an error. An error is signalled by res != NO_ERROR
daladim
force-pushed
the
nic_segfault
branch
4 times, most recently
from
9fcdfc5 to
9145064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
After some time using
heim::net::nic()on Windows (which I implemented some time ago in ad69138), I realized I introduced a potential null pointer dereferencing 😨I've actually ran into this in some tests of mine, that segfaulted when an adapter had not been assigned any IP address.
This MR fixes this issue by properly checking for null pointers where I had forgotten to do so.
Luckily, this bug has never reached a tagged version nor a published version of the
heimcrate incrates.io