heim-cpu: fix glob pattern to support more than 10 cpus #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous glob pattern matched only single-digit CPU numbers. I stumbled across this because vector was not showing more than 10 (the ones that match 0-9) physical cpus using its "host_metrics" source.
As fix, the glob pattern is changed to this:
devices/system/cpu/cpu*/topology/core_id
.Unfortunately
glob::glob()
doesn't support "one or more of this character" like a regex would.So this fix only works until linux adds files that match
cpu*/topology/core_id
but notcpu[0-9]+/topology/core_id
.I consider that highly unlikely. But I there are ways to ensure this never bites us:
.../cpu[0]/...
,.../cpu[0]/...
and.../cpu[0][0][0]/...