This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Mj/die with a quickness #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waiting infinity for sessions to close was causing the swarm_server to never fully die when it was terminated. Why it's own 10s timeout in libp2p_swarm_sup did not come along and brutally kill the process is still a mystery to me.
supervisor is a one_for_all, if anything is going down, it's taking all the sessions with it already. We'll still log to know what is killing the server.
jadeallenx
approved these changes
Nov 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting infinity for sessions to close was causing the swarm_server to
never fully die when it was terminated.
Why it's own 10s timeout in libp2p_swarm_sup did not come along and
brutally kill the process is still a mystery to me.
The supervisor is a one_for_all, if anything is going down, it's taking all
the sessions with it already. We'll still log to know what is killing
the server.