Fix clippy 1.67 warnings #5697
Merged
Fix clippy 1.67 warnings #5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.67 uses features which aren't available on our MSRV. Also the formatting string lint should be disabled: https://twitter.com/adam_chal/status/1618673969590304775 |
mimame
force-pushed
the
fix-clippy-1.67
branch
from
a1c27b4
to
a50ac70
Compare
|
Hi @archseer, I've reduced the changes to only MSRV warnings, If I'm not wrong |
pascalkuthe
reviewed
Jan 27, 2023
pascalkuthe
reviewed
Jan 27, 2023
pascalkuthe
added
E-easy
mimame
force-pushed
the
fix-clippy-1.67
branch
from
a50ac70
to
ae68c14
Compare
mimame
force-pushed
the
fix-clippy-1.67
branch
from
ae68c14
to
b780fb7
Compare
the-mikedavis
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first commit using Rust and to Helix, so I hope to be useful 😄