Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pimu.push_command() out of event loop #107

Open
wants to merge 1 commit into
base: noetic
Choose a base branch
from

Conversation

hello-chintan
Copy link
Contributor

Is there a reason for constantly sending a pimu.push_command() in the main event loop of stretch_driver? If it is just for turning the fan on at startup, could it be handled once outside the loop?

Doing so breaks the runstop service as the runstop trigger and reset methods are not followed by a push command. Have added the fix to this PR.

@hello-fazil
Copy link
Contributor

hello-fazil commented Jul 12, 2023

@hello-chintan
We have seen the Pimu fan turn off by itself a few seconds after turning on the fan with a push command. Therefore as a patch, we push the command to turn on the fan every loop to keep the fan always running. But this should be a harmless push, as trigger syncs are not involved.

@hello-chintan
Copy link
Contributor Author

@hello-fazil Gotcha! Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants