support raw api (#715) #719
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen <[email protected]>
allenhaozi
force-pushed
the
feat/raw-api
branch
from
908f977
to
f0f5a74
Compare
scbizu
requested changes
Sep 17, 2023
| c.JSON(err.Status, gin.H{"error": err.Message}) | ||
| return | ||
| } | ||
| chrt, err1 := loader.LoadArchive(bytes.NewReader(storageObject.Content)) |
There was a problem hiding this comment.
Can we just put this in pkg/repo/chart.go, and provide a function like GetChartRawdate() ?
There was a problem hiding this comment.
thank you for your review
I tried to wrap a function like you said, but I got an error import cycle not allowed
That would require a bigger change, what's your opinion? whether this larger change is needed
|
And also , could you add some testing code to prove the feature is worked as expected ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support raw api
Hi @cbuto @scbizu, as for this raw api, submit a pr version,
please review it. If you have any questions, please feedback to me. Thank you
#715