Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for toYamlPretty #1540

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fheinecke
Copy link

This is a buddy PR for helm/helm#12583. I've added docs for the toYamlPretty function that the aforementioned PR adds. I can add translations as well, but the best I'd be able to do is copy/paste the below change into Google Translate.

@yxxhero
Copy link
Member

yxxhero commented Dec 24, 2023

@fheinecke please fix DCO issue.

Signed-off-by: Fred Heinecke <[email protected]>
@fheinecke
Copy link
Author

@yxxhero fixed - sorry about that.

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero
Copy link
Member

yxxhero commented Feb 2, 2024

Blocked by helm/helm#12583

@jonathino2590
Copy link

Hello how are you? There is a merge date for this PR, so we need it.

@yxxhero
Copy link
Member

yxxhero commented May 16, 2024

@fheinecke please fix conflicts.

@fheinecke
Copy link
Author

@yxxhero Done

@karenhchu karenhchu added the docs label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants