Skip to content

Commit

Permalink
minor - simplify multi-byte unicode char in log message (pytorch#1548)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: pytorch#1548

As title. The log message was (inadvertently?) encoding a ' as a
multi-byte ’ sequence (fancy unicode codepoint 8217 /
U+2019 RIGHT SINGLE QUOTATION MARK -
https://www.codetable.net/decimal/8217). This can make searching for
the log message harder to match. Switch to a simple ascii apostophe
(codepoint 39).

Reviewed By: bigning

Differential Revision: D51726626

fbshipit-source-id: 5e1ecb9ea4eab9ab4f9a0304d53c635015176531
  • Loading branch information
Damian Reeves authored and facebook-github-bot committed Dec 1, 2023
1 parent caac7c0 commit 1de675f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion torchrec/distributed/embedding_lookup.py
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def prefetch(
):
logging.error(
"Invalid setting on SplitTableBatchedEmbeddingBagsCodegen modules. prefetch_pipeline must be set to True.\n"
"If you dont turn on prefetch_pipeline, cache locations might be wrong in backward and can cause wrong results.\n"
"If you don't turn on prefetch_pipeline, cache locations might be wrong in backward and can cause wrong results.\n"
)
if hasattr(emb_op.emb_module, "prefetch"):
emb_op.emb_module.prefetch(
Expand Down

0 comments on commit 1de675f

Please sign in to comment.