Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename wrapper to tab wrapper #4636

Open
wants to merge 4 commits into
base: canary
Choose a base branch
from
+12 −7
Open

fix: rename wrapper to tab wrapper #4636

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3249a52
fix: rename wrapper to tab wrapper
winchesHe Jan 24, 2025
5171be3
docs: update
winchesHe Jan 24, 2025
0e58930
docs: update
winchesHe Jan 27, 2025
20955f3
docs: update
winchesHe Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-ladybugs-whisper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@heroui/theme": patch
---
Comment on lines +1 to +3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Version bump should be major for breaking changes.

The changeset indicates a patch version bump, but the commit message mentions this is a breaking change. According to semver, breaking changes should increment the major version.

Apply this diff to update the version bump:

---
-"@heroui/theme": patch
+"@heroui/theme": major
---
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
---
"@heroui/theme": patch
---
---
"@heroui/theme": major
---


Fix wrapper rename to tabWrapper (#4552)
2 changes: 1 addition & 1 deletion packages/components/tabs/src/use-tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export function useTabs<T extends object>(originalProps: UseTabsProps<T>) {
const getWrapperProps: PropGetter = useCallback(
(props) => ({
"data-slot": "tabWrapper",
className: slots.wrapper({class: clsx(classNames?.wrapper, props?.className)}),
className: slots.tabWrapper({class: clsx(classNames?.tabWrapper, props?.className)}),
"data-placement": placement,
"data-vertical":
isVertical || placement === "start" || placement === "end" ? "vertical" : "horizontal",
Expand Down
8 changes: 4 additions & 4 deletions packages/core/theme/src/components/tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const tabs = tv({
// focus ring
...dataFocusVisibleClasses,
],
wrapper: [],
tabWrapper: [],
},
variants: {
variant: {
Expand Down Expand Up @@ -166,15 +166,15 @@ const tabs = tv({
start: {
tabList: "flex-col",
panel: "py-0 px-3",
wrapper: "flex",
tabWrapper: "flex",
},
end: {
tabList: "flex-col",
panel: "py-0 px-3",
wrapper: "flex flex-row-reverse",
tabWrapper: "flex flex-row-reverse",
},
bottom: {
wrapper: "flex flex-col-reverse",
tabWrapper: "flex flex-col-reverse",
},
},
},
Expand Down
Loading