Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[Feature Request] Auto-Group Based on In-Game Permission Roles #51

Open
Eingang opened this issue Nov 28, 2018 · 2 comments
Open

[Feature Request] Auto-Group Based on In-Game Permission Roles #51

Eingang opened this issue Nov 28, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Eingang
Copy link

Eingang commented Nov 28, 2018

Summary
Ability to auto-group based on static in-game permission roles, like Director, Personnel Manager, etc.

Related
#5

Discussion
While I love the flexibility provided by allowing auto-group based on Corporation Title and that works great if you're using SeAT for your own corporation, it's not so great if you're working with bigger groups. For example, in the use case of trying to Auto-Group for "Director" roles or maybe an "HR" group across an entire alliance, you run into the following issues:

  • Each corporation in an alliance must be individually added when the corporation is/has joined. You can't just select "Alliance" scope.
  • For each corporation, you must pick a specific title, which you may not recognize or may not exist.
  • If you don't already have the corporation in your SeAT somewhere, you can't choose the corporation and you won't have the list of titles available either.
  • Corporations that are no longer in the alliance must be manually removed from the group.
  • If you don't use auto-group, then you need a manual group where you add/remove people as relevant. This is cancer in larger organizations.

Allowing the use of built-in permission roles is what's needed/desired here. Then, where corporations have specific titles for director roles, you can choose to manually add (or not) those special snowflakes later, but the built-in role will cover most situations with no additional manual work required.

While being able to specify any of the built-in permission roles would be lovely, at a bare minimum the following would be useful:

  • Director
  • Personnel Manager
  • Communications Officer
  • Fitting Manager

Suggested Scope Availability
I'd like to see the ability to select by in-game permission role for a specified alliance or a specified corporation.

@herpaderpaldent
Copy link
Owner

herpaderpaldent commented Nov 29, 2018

Hey @Eingang

as this is an awesome feature request i feel obliged to answer you quite thoroughly: I think it is possible, however the way affiliations and the isQualified(Group $group) (the heart of seatgroups) is working would need to be refactored. Doing so introducing testing would be needed to add, as i fear the complexity with all the available affiliations will become to high. These things just add to the size of package that would be needed to develop.

As you might know i am also working on seat core and currently there are more important, cheaper and less complex things in the backlog, this will result in later implementation of this feature.

Furthermore the roles concept of CCP is quite complex: There are 50 (!) roles in 3 configurations to account for:

  • configurations: roles_at_other, roles_at_hq, roles_at_base
  • roles: Account_Take_1, Account_Take_2, Account_Take_3, Account_Take_4, Account_Take_5, Account_Take_6, Account_Take_7, Accountant, Auditor, Communications_Officer, Config_Equipment, Config_Starbase_Equipment, Container_Take_1, Container_Take_2, Container_Take_3, Container_Take_4, Container_Take_5, Container_Take_6, Container_Take_7, Contract_Manager, Diplomat, Director, Factory_Manager, Fitting_Manager, Hangar_Query_1, Hangar_Query_2, Hangar_Query_3, Hangar_Query_4, Hangar_Query_5, Hangar_Query_6, Hangar_Query_7, Hangar_Take_1, Hangar_Take_2, Hangar_Take_3, Hangar_Take_4, Hangar_Take_5, Hangar_Take_6, Hangar_Take_7, Junior_Accountant, Personnel_Manager, Rent_Factory_Facility, Rent_Office, Rent_Research_Facility, Security_Officer, Starbase_Defense_Operator, Starbase_Fuel_Technician, Station_Manager, Terrestrial_Combat_Officer, Terrestrial_Logistics_Officer, Trader

This results in 19600 combinations. I would need from you some kind of acceptance criteria catalogue which would define which role in which configuration should be available and respected. Furthermore a UI Mockup would be appreciated. Whilst you doing this, keep in mind that the affiliation created must be usable for anyone using seat be it Corporation-Setup or Alliance Setup

@Fundaris
Copy link

Fundaris commented Nov 29, 2018

From my pov I would just check if the person has the role and ignoring the configurations.

Also some of the roles are "dead"

If you don't already have the corporation in your SeAT somewhere, you can't choose the corporation and you won't have the list of titles available either.

I also had this issue once with the corp name, but it would be hard to be resolved. Since Eve has no api for that. So you would depend on some thirdparty solution like evewho where you would need to poll and thats something I would personally not like.

For each corporation, you must pick a specific title, which you may not recognize or may not exist.
this would be more a organizing thing on your side.

The title list needs an API so thats a won't fix and also uses uniqueids and using string comparison would have the problems of typos and also that they would be easy to debug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants