Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alice Vision fixes and newer version #1

Open
wants to merge 10,000 commits into
base: alice-vision
Choose a base branch
from

Conversation

zeuner
Copy link

@zeuner zeuner commented Sep 10, 2023

Description of changes

I saw your pull request NixOS#224262 and fixed the build, and added the newer version. I could successfully run a 3D reconstruction through the 3.0.0 build. The 3.1.0 one currently fails here (in contrast to my independently written build NixOS@8411621), which is still to be investigated.

I thought I contribute to your branch instead of adding a separate PR.

This should also help with NixOS#216403

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@zeuner
Copy link
Author

zeuner commented Sep 19, 2023

I also got 3.1.0 to succeed at least on the tests that already succeeded on 3.0.0, and verified it's possible to do some meshing.

I guess it's worth investigating how to get back the better optimization and alignment flags without hurting functionality.

Since both 3.0.0 and 3.1.0 work correctly by now, I guess merging would be reasonable.

NickCao and others added 27 commits January 14, 2024 11:43
…ckages.grafanalib

python311Packages.grafanalib: 0.7.0 -> 0.7.1
python311Packages.soco: 0.30.1 -> 0.30.2
…ckages.idasen

python311Packages.idasen: 0.11.0 -> 0.11.1
…ckages.hahomematic

python311Packages.hahomematic: 2024.1.6 -> 2024.1.7
home-assistant-custom-lovelace-modules.mushroom: 3.2.3 -> 3.2.4
python311Packages.pydrawise: 2024.1.0 -> 2024.1.1
…ckages.epion

python311Packages.epion: 0.0.2 -> 0.0.3
…ckages.fireflyalgorithm

python311Packages.fireflyalgorithm: 0.3.4 -> 0.4.4
…ckages.garth

python311Packages.garth: 0.4.43 -> 0.4.44
…ckages.gotenberg-client

python311Packages.gotenberg-client: 0.4.1 -> 0.5.0
folks: Replace finalAttrs.pname with fixed string folks
 nixos/pcscd: suggest yubikey-personalization, fix restartTriggers
lomiri.lomiri-api: Apply patch for GCC13 support
lovesegfault and others added 24 commits January 15, 2024 13:05
…-pname

nix-cl: provide the original pname as an attribute
…er-browser

aws-azure-login: Link Puppeteer to Chromium
lxd-ui: run nixosTests.lxd.ui by default
poetry: Relax dep requirement check for xattr
…rs-normalize

python311Packages.nose-warnings-filters: rename from nose_warnings_filters
something seems to have went wrong in 24c72d8
but I'm not sure what exactly. re-running the update script does not
reproduce this issue.
…eviewers

doc: mention new documentation-reviewers subteam
…etext

* doc: improve documentation for trivial text writing functions

Co-authored-by: Brian Merchant <[email protected]>
Co-authored-by: Robert Hensing <[email protected]>
Co-authored-by: Alexander Groleau <[email protected]>
Co-authored-by: Valentin Gagarin <[email protected]>
python3Packages.pure-protobuf: 3.0.0 -> 2.3.0
…onventions

doc: reword documentation conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet