forked from NixOS/nixpkgs
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alice Vision fixes and newer version #1
Open
zeuner
wants to merge
10,000
commits into
hesiod:alice-vision
Choose a base branch
from
zeuner:alice-vision
base: alice-vision
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also got 3.1.0 to succeed at least on the tests that already succeeded on 3.0.0, and verified it's possible to do some meshing. I guess it's worth investigating how to get back the better optimization and alignment flags without hurting functionality. Since both 3.0.0 and 3.1.0 work correctly by now, I guess merging would be reasonable. |
zeuner
force-pushed
the
alice-vision
branch
from
September 20, 2023 13:49
10bfc04
to
c47846f
Compare
…ckages.grafanalib python311Packages.grafanalib: 0.7.0 -> 0.7.1
python311Packages.soco: 0.30.1 -> 0.30.2
…ckages.idasen python311Packages.idasen: 0.11.0 -> 0.11.1
…ckages.hahomematic python311Packages.hahomematic: 2024.1.6 -> 2024.1.7
home-assistant-custom-lovelace-modules.mushroom: 3.2.3 -> 3.2.4
python311Packages.pydrawise: 2024.1.0 -> 2024.1.1
…ckages.epion python311Packages.epion: 0.0.2 -> 0.0.3
…ckages.fireflyalgorithm python311Packages.fireflyalgorithm: 0.3.4 -> 0.4.4
…ckages.garth python311Packages.garth: 0.4.43 -> 0.4.44
…ckages.gotenberg-client python311Packages.gotenberg-client: 0.4.1 -> 0.5.0
folks: Replace finalAttrs.pname with fixed string folks
nixos/pcscd: suggest yubikey-personalization, fix restartTriggers
oxlint: 0.0.18 -> 0.1.2
roomeqwizard: 5.20.13 -> 5.30.4
gmic-qt: 3.3.2 -> 3.3.3
lomiri.lomiri-api: Apply patch for GCC13 support
…-pname nix-cl: provide the original pname as an attribute
…er-browser aws-azure-login: Link Puppeteer to Chromium
audio-sharing: init at 0.2.2
zircolite: 2.9.9 -> 2.10.0
pyprland: 1.6.10 -> 1.6.11
lxd-ui: run nixosTests.lxd.ui by default
poetry: Relax dep requirement check for xattr
…rs-normalize python311Packages.nose-warnings-filters: rename from nose_warnings_filters
something seems to have went wrong in 24c72d8 but I'm not sure what exactly. re-running the update script does not reproduce this issue.
…eviewers doc: mention new documentation-reviewers subteam
vector: 0.34.2 → 0.35.0
rmg: init at 0.5.4
swww: 0.8.1 -> 0.8.2
…etext * doc: improve documentation for trivial text writing functions Co-authored-by: Brian Merchant <[email protected]> Co-authored-by: Robert Hensing <[email protected]> Co-authored-by: Alexander Groleau <[email protected]> Co-authored-by: Valentin Gagarin <[email protected]>
python3Packages.pure-protobuf: 3.0.0 -> 2.3.0
…onventions doc: reword documentation conventions
openai-whisper-cpp: 1.5.2 -> 1.5.4
zeuner
force-pushed
the
alice-vision
branch
3 times, most recently
from
January 31, 2024 20:47
1ef48fe
to
f0a8686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I saw your pull request NixOS#224262 and fixed the build, and added the newer version. I could successfully run a 3D reconstruction through the 3.0.0 build. The 3.1.0 one currently fails here (in contrast to my independently written build NixOS@8411621), which is still to be investigated.
I thought I contribute to your branch instead of adding a separate PR.
This should also help with NixOS#216403
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes