Skip to content

Commit

Permalink
Removed non-required helpers (temporalio#6465)
Browse files Browse the repository at this point in the history
## What changed?
<!-- Describe what has changed in this PR -->
- removed helpers which were not being used

## Why?
<!-- Tell your future self why have you made these changes -->
- keeping code nice and clean

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- exiting CI/CD run

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
none

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
- nope
  • Loading branch information
Shivs11 authored Aug 29, 2024
1 parent 1178471 commit c86712f
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions tests/describe_task_queue.go
Original file line number Diff line number Diff line change
Expand Up @@ -210,19 +210,6 @@ func (s *DescribeTaskQueueSuite) publishConsumeWorkflowTasksValidateStats(workfl
s.validateDescribeTaskQueue(tqName, expectedBacklogCount, maxBacklogExtraTasks, expectedAddRate, expectedDispatchRate, isEnhancedMode)
}

func (s *DescribeTaskQueueSuite) isBacklogHeadCreateTimeCorrect(actualBacklogAge time.Duration, expectEmptyBacklog bool) bool {
return expectEmptyBacklog == (actualBacklogAge == time.Duration(0))
}

func (s *DescribeTaskQueueSuite) isAddDispatchTasksRateCorrect(
actualAddTasksRate float32, actualDispatchTasksRate float32, expectAddRate, expectDispatchRate bool) bool {
return expectDispatchRate == (actualDispatchTasksRate != 0) && (expectAddRate == (actualAddTasksRate != 0))
}

func (s *DescribeTaskQueueSuite) isBacklogCountCorrect(actualBacklogCounter int64, expectedBacklogCount int64) bool {
return actualBacklogCounter == expectedBacklogCount
}

func (s *DescribeTaskQueueSuite) validateDescribeTaskQueue(
tq string,
expectedBacklogCount map[enumspb.TaskQueueType]int64,
Expand Down

0 comments on commit c86712f

Please sign in to comment.