Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RIU to default_en.txt #1816

Merged
merged 5 commits into from
May 12, 2024
Merged

Add RIU to default_en.txt #1816

merged 5 commits into from
May 12, 2024

Conversation

PeterKraus
Copy link
Contributor

Hello pint devs! I'd like to add the dimensionless "refractive index units" into pint, as they are often present in raw data files from instruments such as Agilent chromatographs etc. Please let me know if I need to add any tests. Cheers!

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@MichaelTiemannOSC
Copy link
Collaborator

Native support for things that make 🌈 -- love it!!

CHANGES Outdated
@@ -10,6 +10,9 @@ Pint Changelog
(PR #1803)
- Optimize matplotlib unit conversion for Quantity arrays
(PR #1819)
- Added refractory index units.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have this line twice

Copy link

codspeed-hq bot commented May 12, 2024

CodSpeed Performance Report

Merging #1816 will not alter performance

Comparing PeterKraus:riu (84027fd) with master (cb0ec94)

Summary

✅ 437 untouched benchmarks

@andrewgsavage andrewgsavage merged commit 754a7ff into hgrecco:master May 12, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants