Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [+-]portion.inf to upcast_types #1889

Closed
wants to merge 1 commit into from
Closed

Add [+-]portion.inf to upcast_types #1889

wants to merge 1 commit into from

Conversation

gsakkis
Copy link

@gsakkis gsakkis commented Dec 6, 2023

@AlexandreDecan
Copy link

Notice that the two paths (portion.const._PInf and portion.const._NInf) are part of the private API of portion. I don't know to which extent this private API will be subject to changes in the future. At the same time, I don't see any other good alternative :-)

Copy link

codspeed-hq bot commented Dec 27, 2023

CodSpeed Performance Report

Merging #1889 will not alter performance

Comparing gsakkis:master (e81d413) with master (57764be)

Summary

✅ 439 untouched benchmarks

@gsakkis
Copy link
Author

gsakkis commented Jan 10, 2024

@andrewgsavage could you take a look?

@andrewgsavage
Copy link
Collaborator

looks fine, just needs a maintainer to merge it.

Notice that the two paths (portion.const._PInf and portion.const._NInf) are part of the private API of portion. I don't know to which extent this private API will be subject to changes in the future. At the same time, I don't see any other good alternative :-)

just needs a new PR with changes if you do end up changing it.

@andrewgsavage
Copy link
Collaborator

Why was this closed? Do you not want it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quantity intervals
3 participants