Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated definition of US survey units to reflect the 2022 revision by NIST/NGS #1920

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated definition of US survey units to reflect the 2022 revision by NIST/NGS #1920

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f248aaa
Updated definition of US survey units to reflect the 2022 revision by…
jacob-indigo Jan 11, 2024
5385a54
Fix whitespace
jacob-indigo Jan 11, 2024
c1f76e3
Updated sources
jacob-indigo Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Pint Changelog
0.24 (unreleased)
-----------------

- Nothing changed yet.
- Updated definition of US survey units to reflect the 2022 revision by NIST/NGS


0.23 (2023-12-08)
Expand Down
36 changes: 22 additions & 14 deletions pint/default_en.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,23 +538,31 @@ neper = 1 ; logbase: 2.71828182845904523536028747135266249775724709369995; logfa
cubic_yard = yd ** 3 = cu_yd
@end

# Note: historically, many of the units in this group were derived from each other (e.g. 1 chain = 10 fathoms = 4 rods = 100 links)
# but we've followed the NIST's lead here and defined all of the units directly based on "common" units (feet and miles)
# Source: U.S. Survey Foot: Revised Unit Conversion Factors <https://www.nist.gov/pml/us-surveyfoot/revised-unit-conversion-factors>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blog-like post may disappear. The real citation that you could add as proposed at the bottom of #1912 (comment) is:
Warfield, L. , Konijnenburg, J. , Lippa, K. , Lee, G. , Minnich, L. and Williams, J. (2023), Specifications, Tolerances, and Other Technical Requirements for Weighing and Measuring Devices as adopted by the 108th National Conference on Weights and Measures, Handbook (NIST HB), National Institute of Standards and Technology, Gaithersburg, MD, [online], https://doi.org/10.6028/NIST.HB.44-2024, https://tsapps.nist.gov/publication/get_pdf.cfm?pub_id=956954 (Accessed January 11, 2024)

Copy link
Contributor

@dalito dalito Jan 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle the DOI would be enough. Minimal form of reference:
Handbook (NIST HB) - 44-2024, http://dx.doi.org/https://doi.org/10.6028/NIST.HB.44-2024

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I updated both sources accordingly.

@group USCSLengthSurvey
link = 1e-2 * chain = li = survey_link
survey_foot = 1200 / 3937 * meter = sft
fathom = 6 * survey_foot
rod = 16.5 * survey_foot = rd = pole = perch
chain = 4 * rod
furlong = 40 * rod = fur
cables_length = 120 * fathom
survey_mile = 5280 * survey_foot = smi = us_statute_mile
league = 3 * survey_mile

square_rod = rod ** 2 = sq_rod = sq_pole = sq_perch
acre = 10 * chain ** 2
square_survey_mile = survey_mile ** 2 = _ = section
cables_length = 720 * foot
chain = 66 * foot = ch
fathom = 6 * foot
furlong = 660 * foot = fur
league = 3 * mile
link = 0.66 * foot = li = survey_link
rod = 16.5 * foot = rd = pole = perch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the order from small to big length unit to make diffs simpler to follow

square_rod = rod ** 2 = sq_rd = sq_rod = sq_pole = sq_perch
acre = 43560 * square_foot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could leave it as is was to minimize diffs. acre = 10 * chain ** 2

square_league = league ** 2
acre_foot = acre * foot = _ = acre_feet
@end

acre_foot = acre * survey_foot = _ = acre_feet
# The adoption of the international foot in 1959 temporarily permitted the continued use of the 1893 definition of the foot for survey purposes.
# That established the Survey Foot. After 2022, that exception was no longer permitted and all feet are feet (survey or otherwise).
# Source: U.S. Survey Foot <https://www.nist.gov/pml/us-surveyfoot>
@group USCSLengthSurveyMendenhall
survey_foot = 1200 / 3937 * meter = sft
survey_mile = 5280 * survey_foot = smi = us_statute_mile
square_survey_mile = survey_mile ** 2
@end

@group USCSDryVolume
Expand Down