Fix cli uncertainty package import #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… package * This changes the default behaviour for importing "uncertainties" package in cli, as it was enabled by default and was imported even if it was an optional package. * The default behaviour of the convert function has been adjusted accordingly to only consider 'uncertainties' if the argument "-U" or "--with-unc" is provided.
* The changes in the document illustrate how the `-U` flag is used to enable uncertainty in the pint-convert program. * Previously, the documentation indicated that the `-U` flag was used to disable uncertainty, but based on current changes `-U` flag would indicate `-U` is enabled. * Updates also include modifications for multiple examples demonstrating the proper `-U` flag usage.
CodSpeed Performance ReportMerging #2032 will not alter performanceComparing Summary
|
* Added try/except blocks to handle ImportError and AttributeError in pint_convert.py. Now the code tries to import the 'uncertainties' library and falls back to raise an exception if the library is not present. * Similarly, an AttributeError is caught when calculating correlation of values which requires numpy, prompting users to install the package if not available.
doronbehar
reviewed
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-fileswith no errors