Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GenericPlainRegistry getattr type #2045

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Conversation

theodotk
Copy link
Contributor

@theodotk theodotk commented Aug 12, 2024

I'm aware that there exists PR #1948 , but it's not been merged for a while

@theodotk theodotk changed the title fix getarrt type fix GenericPlainRegistry getattr type Aug 12, 2024
@andrewgsavage
Copy link
Collaborator

thanks, those tests make it clear what's intended.

Copy link

codspeed-hq bot commented Aug 19, 2024

CodSpeed Performance Report

Merging #2045 will not alter performance

Comparing theodotk:master (e0375e9) with master (0b0ae61)

Summary

✅ 437 untouched benchmarks

@andrewgsavage andrewgsavage merged commit 8f12bb9 into hgrecco:master Aug 19, 2024
53 checks passed
@theodotk
Copy link
Contributor Author

@andrewgsavage @hgrecco could you please make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy error: ureg.m annotation is expected to be Quantity instead of Unit
2 participants