fix: workaround external require on ssr

hi-ogawa · Nov 11, 2024 · 24a995f · 24a995f
1 parent a282d91
commit 24a995f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/packages/vite/src/node/server/environments/rolldown.ts b/packages/vite/src/node/server/environments/rolldown.ts
@@ -202,9 +202,15 @@ export class RolldownEnvironment extends DevEnvironment {
     // `generate` should work but we use `write` so it's easier to see output and debug
     const outputOptions: rolldown.OutputOptions = {
       dir: this.outDir,
-      format: this.rolldownDevOptions.hmr ? 'app' : 'es',
+      format: this.rolldownDevOptions.hmr ? 'app' : 'esm',
       // TODO: hmr_rebuild returns source map file when `sourcemap: true`
       sourcemap: 'inline',
+      // TODO: https://github.com/rolldown/rolldown/issues/2041
+      // handle `require("stream")` in `react-dom/server`
+      banner:
+        this.name === 'ssr'
+          ? `import __nodeModule from "node:module"; const require = __nodeModule.createRequire(import.meta.url);`
+          : undefined,
     }
     this.result = await this.instance.write(outputOptions)
 

diff --git a/playground/rolldown-dev-ssr/src/ambient.d.ts b/playground/rolldown-dev-ssr/src/ambient.d.ts
diff --git a/playground/rolldown-dev-ssr/src/entry-server.tsx b/playground/rolldown-dev-ssr/src/entry-server.tsx
@@ -1,4 +1,4 @@
-import ReactDOMServer from 'react-dom/server.browser'
+import ReactDOMServer from 'react-dom/server'
 import type { Connect } from 'vite'
 import { App } from './app'
 

diff --git a/playground/rolldown-dev-ssr/vite.config.ts b/playground/rolldown-dev-ssr/vite.config.ts
@@ -1,5 +1,7 @@
 import { defineConfig } from 'vite'
 
+process.setSourceMapsEnabled(true)
+
 export default defineConfig({
   environments: {
     client: {