fix: fix import.meta.hot.on

hi-ogawa · Dec 5, 2024 · bda4da7 · bda4da7
1 parent a652589
commit bda4da7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/packages/vite/misc/rolldown-runtime.js b/packages/vite/misc/rolldown-runtime.js
@@ -126,8 +126,6 @@ var rolldown_runtime = (self.rolldown_runtime = {
             })
           }
         },
-        // TODO: import.meta.hot.on
-        on: () => {},
       },
     })
     this.executeModuleStack.push(id)

diff --git a/packages/vite/src/node/server/environments/rolldown.ts b/packages/vite/src/node/server/environments/rolldown.ts
@@ -244,7 +244,8 @@ class RolldownEnvironment extends DevEnvironment {
             },
             handler(code) {
               const output = new MagicString(code)
-              output.replaceAll('import.meta.hot', 'module.hot')
+              output.replaceAll('import.meta.hot.accept', 'module.hot.accept')
+              output.replaceAll('import.meta.hot.on', 'self.__rolldown_hot.on')
               return { code: output.toString(), map: output.generateMap() }
             },
           },

diff --git a/playground/rolldown-dev-vue/vite.config.ts b/playground/rolldown-dev-vue/vite.config.ts
@@ -8,13 +8,5 @@ export default defineConfig({
       hmr: true,
     },
   },
-  plugins: [
-    vue(),
-    {
-      name: 'debug',
-      buildEnd(err) {
-        console.log('[buildEnd]', err)
-      },
-    },
-  ],
+  plugins: [vue()],
 })
-Original file line number
+Diff line change
@@ Expand Up / @@ -126,8 +126,6 @@ var rolldown_runtime = (self.rolldown_runtime = { @@
                 })
               }
             },
-            // TODO: import.meta.hot.on
-            on: () => {},
           },
         })
         this.executeModuleStack.push(id)
@@ Expand Down @@