fix: use createBuiltinPluginWithEnvironmentSupport for transformPlugin

hi-ogawa · Nov 11, 2024 · dfd18c5 · dfd18c5
1 parent 75bca17
commit dfd18c5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/packages/vite/src/node/plugins/index.ts b/packages/vite/src/node/plugins/index.ts
@@ -125,12 +125,18 @@ export async function resolvePlugins(
     htmlInlineProxyPlugin(config),
     cssPlugin(config),
     config.oxc !== false
-      ? enableNativePlugin
-        ? nativeTransformPlugin({
-            // TODO: how to jsx dev?
-            reactRefresh: rolldownDev?.reactRefresh,
-          })
-        : oxcPlugin(config)
+      ? rolldownDev
+        ? createBuiltinPluginWithEnvironmentSupport(
+            'native:transform',
+            (environment) =>
+              nativeTransformPlugin({
+                reactRefresh:
+                  environment.name === 'client' && rolldownDev?.reactRefresh,
+              }),
+          )
+        : enableNativePlugin
+          ? nativeTransformPlugin()
+          : oxcPlugin(config)
       : null,
     enableNativePlugin
       ? nativeJsonPlugin({

diff --git a/packages/vite/src/node/server/environments/rolldown.ts b/packages/vite/src/node/server/environments/rolldown.ts
@@ -221,8 +221,7 @@ class RolldownEnvironment extends DevEnvironment {
 
     // all plugins are shared like Vite 6 `sharedConfigBuild`.
     let plugins = this._plugins!
-    // enable some core plugins
-    // TODO: adopt more (should we filter inside `resolvePlugins`?)
+    // TODO: enable more core plugins
     plugins = plugins.filter(
       (p) =>
         !(typeof p.name === 'number' || p.name?.startsWith('vite:')) ||