chore: remove debug-env api (#532)

hi-ogawa · Dec 26, 2023 · 3845450 · 3845450
1 parent e0a4aea
commit 3845450
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 48 deletions.
diff --git a/app/routes/dev/debug-env.tsx b/app/routes/dev/debug-env.tsx
diff --git a/app/utils/auth.ts b/app/utils/auth.ts
@@ -1,11 +1,7 @@
 import { tinyassert } from "@hiogawa/utils";
 import { E, T, db, selectOne } from "../db/drizzle-client.server";
 import type { UserTable } from "../db/models";
-import {
-  toPasswordHash,
-  verifyPassword,
-  verifyPasswordNoop,
-} from "./password-utils";
+import { toPasswordHash, verifyPassword } from "./password-utils";
 
 const DEFAULT_TIMEZONE = "+00:00";
 
@@ -55,7 +51,6 @@ export async function verifySignin(data: {
     E.eq(T.users.username, data.username)
   );
   if (!user) {
-    await verifyPasswordNoop();
     return false;
   }
   return await verifyPassword(data.password, user.passwordHash);

diff --git a/app/utils/password-utils.ts b/app/utils/password-utils.ts
@@ -48,13 +48,3 @@ export async function verifyPassword(
 
   return worker.argon2.verify_password(password, passwordHash);
 }
-
-// fake verification for timing safety?
-export async function verifyPasswordNoop() {
-  await verifyPassword(
-    "noop-for-timing-safety",
-    // dummy hash generated by
-    //   node -r esbuild-register -e 'lib = require("./app/utils/password-utils.ts"); lib.initializeArgon2().then(() => lib.toPasswordHash("").then(console.log))'
-    "$argon2id$v=19$m=19456,t=2,p=1$9i2rshv5CH6kecJSbN0pLw$sCqIUzQzO2gC+TewudcBIcGX9kPtxIaXCaIbEiX7ecI"
-  );
-}