chore: enable React.StrictMode
#370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This flaky-ness might be just inherent one and not related to strict mode double effect https://github.com/hi-ogawa/ytsub-v3/actions/runs/4899808342/jobs/8750039188#step:9:58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we got some non-pure code a lot even though it works in practice.
Let's setup
React.StrictModeto see how much it would break.(Also I'm more interested in dog-fooding
utils-reactpackage to see if they have a problem)todo
react-querymutatein effect 4842ddevery ridiculous workaround...? 85e0137useEffectNoStrictseems fineuseIntersectionObserver629ae4a