Remove token thresholds from server (#6105)

* remove client side gating flag + topic threshold logic * remove token balance property + methods from client Account model * remove more token threshold logic from client * remove env var from webpack * remove ITokenAdapter * removed banner * removed NftAdapter * remove token adapters * remove .only in API tests * eslint fixes * `Topics.token_threshold` removal migration * remove `/bulkBalances` * remove `/tokenBalance` * remove `/tokenBalance` - external API * remove test + types * remove token_balance requirement in created_topics to fix topic creation * remove unused error * remove validateTopicThreshold * fix unit tests * remove token_threshold from sequelize model + delete `/setTopicThreshold` * remove setTopicThreshold mutation * reorder migration * add gating flag to unit tests * integration test fix * fix unit test * fix sublayout banner * invert flag check * fix unit tests
hicommonwealth · Jan 4, 2024 · 4f8f902 · 4f8f902
1 parent 451890f
commit 4f8f902
Show file tree

Hide file tree

Showing 22 changed files with 162 additions and 621 deletions.
diff --git a/packages/commonwealth/package.json b/packages/commonwealth/package.json
@@ -55,7 +55,7 @@
     "test-integration-util": "NODE_ENV=test nyc ts-mocha --project tsconfig.json ./test/integration/*.spec.ts",
     "test-select": "NODE_ENV=test nyc ts-mocha --project tsconfig.json",
     "test-suite": "NODE_ENV=test nyc ts-mocha --project tsconfig.json './test/**/*.spec.ts'",
-    "unit-test": "NODE_ENV=test ts-mocha --project tsconfig.json './test/unit/**/*.spec.ts'",
+    "unit-test": "NODE_ENV=test FEATURE_FLAG_GROUP_CHECK_ENABLED=true ts-mocha --project tsconfig.json './test/unit/**/*.spec.ts'",
     "unit-test:watch": "NODE_ENV=test ts-mocha --project tsconfig.json --opts test/mocha-dev.opts './test/unit/**/*.spec.ts' -w --watch-files '**/*.ts'",
     "wait-server": "chmod +x ./scripts/wait-server.sh && ./scripts/wait-server.sh",
     "refresh-all-memberships": "npx ts-node -T ./scripts/refresh-all-memberships.ts",

diff --git a/packages/commonwealth/server/api/extApiTypes.ts b/packages/commonwealth/server/api/extApiTypes.ts
@@ -8,7 +8,6 @@ import type { CommentAttributes } from '../models/comment';
 import type { CommunityAttributes } from '../models/community';
 import type { ProfileAttributes } from '../models/profile';
 import type { ReactionAttributes } from '../models/reaction';
-import type { RoleAttributes } from '../models/role';
 import type { ThreadAttributes } from '../models/thread';
 import type { TopicAttributes } from '../models/topic';
 
@@ -95,10 +94,6 @@ export type GetProfilesReq = {
   count_only?: boolean;
 } & IPagination;
 
-export type PostProfilesReq = {
-  profiles: (ProfileAttributes[] & { community_id: string })[];
-};
-
 export type GetProfilesResp = { profiles?: ProfileAttributes[]; count: number };
 
 export type GetChainNodesReq = {
@@ -117,13 +112,6 @@ export type GetBalanceProvidersResp = {
   count: number;
 };
 
-export type GetTokenBalanceReq = {
-  chain_node_id: number;
-  addresses: string[];
-  balance_provider: string;
-  opts: Record<string, string | undefined>;
-};
-
 export type GetTopicsReq = {
   community_id: string;
   count_only?: boolean;
@@ -135,19 +123,6 @@ export type PostTopicsReq = {
 
 export type GetTopicsResp = { topics?: TopicAttributes[]; count: number };
 
-export type GetRolesReq = {
-  community_id: string;
-  addresses?: string[];
-  count_only?: boolean;
-  permissions?: string[];
-} & IPagination;
-
-export type GetRolesResp = { roles?: RoleAttributes[]; count: number };
-
-export type PostRolesReq = {
-  roles: (RoleAttributes & { community_id: string })[];
-};
-
 export type OnlyErrorResp = { error?: string | object };
 
 export const needParamErrMsg = 'Please provide a parameter to query by';
diff --git a/packages/commonwealth/server/controllers/server_comments_methods/create_comment_reaction.ts b/packages/commonwealth/server/controllers/server_comments_methods/create_comment_reaction.ts
@@ -97,7 +97,6 @@ export async function __createCommentReaction(
       try {
         const { isValid } = await validateTopicGroupsMembership(
           this.models,
-          this.tokenBalanceCacheV1,
           this.tokenBalanceCacheV2,
           thread.topic_id,
           community,

diff --git a/packages/commonwealth/server/controllers/server_polls_methods/update_poll_vote.ts b/packages/commonwealth/server/controllers/server_polls_methods/update_poll_vote.ts
@@ -70,7 +70,6 @@ export async function __updatePollVote(
     // check token balance threshold if needed
     const { isValid } = await validateTopicGroupsMembership(
       this.models,
-      this.tokenBalanceCacheV1,
       this.tokenBalanceCacheV2,
       thread.topic_id,
       community,

diff --git a/packages/commonwealth/server/controllers/server_threads_methods/create_thread.ts b/packages/commonwealth/server/controllers/server_threads_methods/create_thread.ts
@@ -179,7 +179,6 @@ export async function __createThread(
         if (!isAdmin) {
           const { isValid, message } = await validateTopicGroupsMembership(
             this.models,
-            this.tokenBalanceCacheV1,
             this.tokenBalanceCacheV2,
             topicId,
             community,

diff --git a/packages/commonwealth/server/controllers/server_threads_methods/create_thread_comment.ts b/packages/commonwealth/server/controllers/server_threads_methods/create_thread_comment.ts
@@ -138,7 +138,6 @@ export async function __createThreadComment(
     if (!isAdmin) {
       const { isValid, message } = await validateTopicGroupsMembership(
         this.models,
-        this.tokenBalanceCacheV1,
         this.tokenBalanceCacheV2,
         thread.topic_id,
         community,

diff --git a/packages/commonwealth/server/controllers/server_threads_methods/create_thread_reaction.ts b/packages/commonwealth/server/controllers/server_threads_methods/create_thread_reaction.ts
@@ -95,7 +95,6 @@ export async function __createThreadReaction(
     if (!isAdmin) {
       const { isValid, message } = await validateTopicGroupsMembership(
         this.models,
-        this.tokenBalanceCacheV1,
         this.tokenBalanceCacheV2,
         thread.topic_id,
         community,

diff --git a/packages/commonwealth/server/migrations/20231215165406-remove-topic-threshold.js b/packages/commonwealth/server/migrations/20231215165406-remove-topic-threshold.js
@@ -0,0 +1,21 @@
+'use strict';
+
+module.exports = {
+  up: async (queryInterface, Sequelize) => {
+    await queryInterface.removeColumn('Topics', 'token_threshold');
+  },
+
+  down: async (queryInterface, Sequelize) => {
+    // data loss occurs
+    await queryInterface.addColumn(
+      'Topics',
+      'token_threshold',
+      {
+        type: Sequelize.STRING,
+        allowNull: true,
+        defaultValue: '0',
+      },
+      { transaction: t },
+    );
+  },
+};
diff --git a/packages/commonwealth/server/models/topic.ts b/packages/commonwealth/server/models/topic.ts
@@ -17,7 +17,6 @@ export type TopicAttributes = {
   created_at?: Date;
   updated_at?: Date;
   deleted_at?: Date;
-  token_threshold: string;
   default_offchain_template?: string;
   group_ids: number[];
 
@@ -47,7 +46,6 @@ export default (
       created_at: { type: dataTypes.DATE, allowNull: false },
       updated_at: { type: dataTypes.DATE, allowNull: false },
       deleted_at: { type: dataTypes.DATE, allowNull: true },
-      token_threshold: { type: dataTypes.STRING, allowNull: true },
       featured_in_sidebar: {
         type: dataTypes.BOOLEAN,
         allowNull: true,

diff --git a/packages/commonwealth/server/routes/bulkBalances.ts b/packages/commonwealth/server/routes/bulkBalances.ts
diff --git a/packages/commonwealth/server/routes/getTokenBalance.ts b/packages/commonwealth/server/routes/getTokenBalance.ts
diff --git a/packages/commonwealth/server/routes/setTopicThreshold.ts b/packages/commonwealth/server/routes/setTopicThreshold.ts