use enum for health

hicommonwealth · Feb 8, 2024 · 974d1fa · 974d1fa
1 parent 8b8309a
commit 974d1fa
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/libs/core/src/types.ts b/libs/core/src/types.ts
@@ -239,3 +239,8 @@ export type ChainEventNotification = {
   created_at: Date;
   ChainEvent: ChainEventAttributes;
 };
+
+export enum NodeHealth {
+  Failed = 'failed',
+  Healthy = 'healthy',
+}
diff --git a/libs/model/src/models/chain_node.ts b/libs/model/src/models/chain_node.ts
@@ -1,4 +1,4 @@
-import type { BalanceType } from '@hicommonwealth/core';
+import type { BalanceType, NodeHealthState } from '@hicommonwealth/core';
 import type * as Sequelize from 'sequelize'; // must use "* as" to avoid scope errors
 import type { DataTypes } from 'sequelize';
 import type { ModelInstance, ModelStatic } from './types';
@@ -15,7 +15,7 @@ export type ChainNodeAttributes = {
   ss58?: number;
   name: string;
   description?: string;
-  health?: string;
+  health?: NodeHealthState;
   updated_at?: Date;
 };
 
@@ -43,7 +43,7 @@ export default (
       balance_type: { type: dataTypes.STRING, allowNull: false },
       name: { type: dataTypes.STRING, allowNull: false },
       description: { type: dataTypes.TEXT, allowNull: true },
-      health: { type: dataTypes.TEXT, allowNull: true },
+      health: { type: dataTypes.STRING, allowNull: true },
       ss58: { type: dataTypes.INTEGER, allowNull: true },
       bech32: { type: dataTypes.STRING, allowNull: true },
       created_at: { type: dataTypes.DATE, allowNull: false },

diff --git a/packages/commonwealth/server/util/cosmosProxy.ts b/packages/commonwealth/server/util/cosmosProxy.ts
@@ -2,7 +2,7 @@ import {
   CacheDecorator,
   lookupKeyDurationInReq,
 } from '@hicommonwealth/adapters';
-import { AppError, logger } from '@hicommonwealth/core';
+import { AppError, NodeHealth, logger } from '@hicommonwealth/core';
 import { DB } from '@hicommonwealth/model';
 import axios from 'axios';
 import bodyParser from 'body-parser';
@@ -49,7 +49,7 @@ function setupCosmosProxy(
         chainNodeUrl = chainNode?.url?.trim();
         let useProxy = !chainNodeUrl;
         cosmos_chain_id = chainNode?.cosmos_chain_id;
-        previouslyFailed = chainNode?.health?.includes('failed');
+        previouslyFailed = chainNode?.health === NodeHealth.Failed;
         if (previouslyFailed) {
           const lastUpdate = chainNode?.updated_at?.getTime();
           const healthPauseTimeout = new Date(
@@ -131,7 +131,7 @@ function setupCosmosProxy(
         cosmos_chain_id = chainNode.cosmos_chain_id;
         chainNodeRestUrl = chainNode.alt_wallet_url?.trim();
         let useProxy = !chainNodeRestUrl;
-        previouslyFailed = chainNode.health?.includes('failed');
+        previouslyFailed = chainNode?.health === NodeHealth.Failed;
 
         if (previouslyFailed) {
           const lastUpdate = chainNode.updated_at?.getTime();
@@ -230,7 +230,7 @@ function setupCosmosProxy(
     const failedChainNode = await models.ChainNode.findOne({
       where: { cosmos_chain_id },
     });
-    failedChainNode.health = 'failed';
+    failedChainNode.health = NodeHealth.Failed;
     await failedChainNode.save();
     log.trace(
       `Problem with endpoint ${failedUrl}. Marking node as 'failed' for ${FALLBACK_NODE_DURATION} seconds.`,
@@ -249,7 +249,7 @@ function setupCosmosProxy(
       const healthyChainNode = await models.ChainNode.findOne({
         where: { cosmos_chain_id },
       });
-      healthyChainNode.health = 'healthy';
+      healthyChainNode.health = NodeHealth.Healthy;
       await healthyChainNode.save();
     }
   };