thread creation + edit without encoding

hicommonwealth · Sep 11, 2024 · de2d6a1 · de2d6a1
1 parent 5b6bd90
commit de2d6a1
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 13 deletions.
diff --git a/libs/model/src/thread/CreateThread.command.ts b/libs/model/src/thread/CreateThread.command.ts
@@ -16,13 +16,7 @@ import { verifyThreadSignature } from '../middleware/canvas';
 import { mustBeAuthorized } from '../middleware/guards';
 import { getThreadSearchVector } from '../models/thread';
 import { tokenBalanceCache } from '../services';
-import {
-  emitMentions,
-  parseUserMentions,
-  quillToPlain,
-  sanitizeQuillText,
-  uniqueMentions,
-} from '../utils';
+import { emitMentions, parseUserMentions, uniqueMentions } from '../utils';
 
 export const CreateThreadErrors = {
   InsufficientTokenBalance: 'Insufficient token balance',
@@ -112,8 +106,7 @@ export function CreateThread(): Command<
         checkContestLimits(activeContestManagers, actor.address!);
       }
 
-      const body = sanitizeQuillText(payload.body);
-      const plaintext = kind === 'discussion' ? quillToPlain(body) : body;
+      const body = payload.body;
       const mentions = uniqueMentions(parseUserMentions(body));
 
       // == mutation transaction boundary ==

diff --git a/packages/commonwealth/client/scripts/state/api/threads/createThread.ts b/packages/commonwealth/client/scripts/state/api/threads/createThread.ts
@@ -42,7 +42,7 @@ export const buildCreateThreadInput = async ({
     community_id: communityId,
     topic_id: topic.id,
     title: encodeURIComponent(title),
-    body: encodeURIComponent(body ?? ''),
+    body: body ?? '',
     kind,
     stage,
     url,

diff --git a/packages/commonwealth/client/scripts/state/api/threads/editThread.ts b/packages/commonwealth/client/scripts/state/api/threads/editThread.ts
@@ -84,7 +84,7 @@ const editThread = async ({
     jwt: userStore.getState().jwt,
     // for edit profile
     ...(url && { url }),
-    ...(newBody && { body: encodeURIComponent(newBody) }),
+    ...(newBody && { body: newBody }),
     ...(newTitle && { title: encodeURIComponent(newTitle) }),
     ...(authorProfile && { author: JSON.stringify(authorProfile) }),
     // for editing thread locked status

diff --git a/packages/commonwealth/client/scripts/views/pages/view_thread/edit_body.tsx b/packages/commonwealth/client/scripts/views/pages/view_thread/edit_body.tsx
@@ -11,7 +11,10 @@ import { openConfirmation } from 'views/modals/confirmation_modal';
 import type Thread from '../../../models/Thread';
 import { CWButton } from '../../components/component_kit/new_designs/CWButton';
 import { ReactQuillEditor } from '../../components/react_quill_editor';
-import { deserializeDelta } from '../../components/react_quill_editor/utils';
+import {
+  deserializeDelta,
+  serializeDelta,
+} from '../../components/react_quill_editor/utils';
 import { clearEditingLocalStorage } from '../discussions/CommentTree/helpers';
 
 type EditBodyProps = {
@@ -93,7 +96,7 @@ export const EditBody = (props: EditBodyProps) => {
       try {
         const newBody = JSON.stringify(contentDelta);
         await editThread({
-          newBody: JSON.stringify(contentDelta) || thread.body,
+          newBody: serializeDelta(contentDelta) || thread.body,
           newTitle: title || thread.title,
           threadId: thread.id,
           authorProfile: user.activeAccount?.profile,