Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try v1 when v1beta1 proposal fetch fails #6070

Closed
mhagel opened this issue Dec 15, 2023 · 0 comments · Fixed by #6097
Closed

Try v1 when v1beta1 proposal fetch fails #6070

mhagel opened this issue Dec 15, 2023 · 0 comments · Fixed by #6097
Assignees
Labels
5 Few days task Cosmos enhancement New feature or request

Comments

@mhagel
Copy link
Contributor

mhagel commented Dec 15, 2023

Description

If a Cosmos chain decides to use gov v1 and we don't know about it, their proposals don't load properly.

We should handle this case.

Project Owner

Engineering Requirements

Acceptance Criteria

  • If a v1beta1 Cosmos proposal fetch fails for a known case, like:
    Error fetching proposals by status PROPOSAL_STATUS_PASSED Error: Query failed with (6): can't convert a gov/v1 Proposal to gov/v1beta1 Proposal when amount of proposal messages not exactly one: invalid type: unknown request,
    then attempt to fetch via the v1 API.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Few days task Cosmos enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant