Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phantom pulled up by error when calling switch network for metamask #9177

Closed
ianrowan opened this issue Sep 10, 2024 · 0 comments · Fixed by #9178
Closed

Phantom pulled up by error when calling switch network for metamask #9177

ianrowan opened this issue Sep 10, 2024 · 0 comments · Fixed by #9178
Assignees
@ianrowan
Labels
1 1-2 hour task bug Something isn't working

Comments

@ianrowan
Copy link
Contributor

Description

I noticed that with metamask and phantom installed the switch network stage of the contract calls was pulling up phantom and creating an error.

It turns out phantom(like coinbase wallet) has injected into the notorious window.ethereum causing override of metamask requests that dont use the direct rpc. All usage should be fixed in the web wallet
@ianrowan ianrowan added bug Something isn't working 1 1-2 hour task labels Sep 10, 2024
@ianrowan ianrowan self-assigned this Sep 10, 2024
@ianrowan ianrowan linked a pull request Sep 10, 2024 that will close this issue
Fix window.ethereum usage to avoid phantom pop up #9178
Merged
@ianrowan ianrowan mentioned this issue Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianrowan ianrowan

Labels
1 1-2 hour task bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix window.ethereum usage to avoid phantom pop up hicommonwealth/commonwealth
1 participant
@ianrowan